Skip to content

fix(test): impact analysis selector fix#27118

Merged
mohityadav766 merged 6 commits into1.12.5from
fix-impact-analysis-tests
Apr 7, 2026
Merged

fix(test): impact analysis selector fix#27118
mohityadav766 merged 6 commits into1.12.5from
fix-impact-analysis-tests

Conversation

@chirag-madlani
Copy link
Copy Markdown
Collaborator

@chirag-madlani chirag-madlani commented Apr 7, 2026

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Test selector updates:
    • Replaced testid selectors with accessible role-based queries for filter buttons and export buttons in impact analysis and lineage tests
    • Updated entity search index mappings to use suffixed format (e.g., tabletable_search_index)
  • Test reliability fixes:
    • Changed Impact Analysis tab selector from role: 'tab' to role: 'button'
    • Added redirectToHomePage() calls in beforeEach hooks for lineage test suites

This will update automatically on new commits.

@chirag-madlani chirag-madlani requested a review from a team as a code owner April 7, 2026 07:17
@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

❌ Lint Check Failed — ESLint + Prettier (core-components)

The following files have style issues that need to be fixed:

Fix locally (fast — only for changed files in the branch):

make ui-checkstyle-core-components-changed

Or to fix all files:

make ui-checkstyle-core-components

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

❌ Playwright Lint Check Failed — ESLint + Prettier + Organise Imports

The following files have style issues that need to be fixed:
playwright/e2e/Features/ImpactAnalysis.spec.ts playwright/e2e/Pages/Lineage/DataAssetLineage.spec.ts playwright/e2e/Pages/Lineage/LineageFilters.spec.ts playwright/e2e/Pages/Lineage/PlatformLineage.spec.ts playwright/utils/common.ts playwright/utils/lineage.ts

Fix locally (fast — only for changed files in the branch):

make ui-checkstyle-playwright-changed

Or to fix all playwright files:

make ui-checkstyle-playwright

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.97% (57435/87059) 45.64% (30358/66514) 48.41% (9115/18828)

@gitar-bot
Copy link
Copy Markdown

gitar-bot bot commented Apr 7, 2026

Code Review ✅ Approved

Fixes impact analysis selector test failures across multiple spec files including lineage, filter button, and missing piece issues. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 7, 2026

@mohityadav766 mohityadav766 merged commit 9b25b26 into 1.12.5 Apr 7, 2026
35 of 41 checks passed
@mohityadav766 mohityadav766 deleted the fix-impact-analysis-tests branch April 7, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants